Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Markdown print error in 1.12.0-DEV #358

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Fix Markdown print error in 1.12.0-DEV #358

merged 1 commit into from
Jul 3, 2024

Conversation

huangyxi
Copy link
Contributor

@huangyxi huangyxi commented Jul 3, 2024

@KristofferC KristofferC merged commit c30b072 into KristofferC:master Jul 3, 2024
9 of 10 checks passed
@huangyxi
Copy link
Contributor Author

huangyxi commented Jul 3, 2024

Performance improvement:

if isdefined(Markdown, :lines)
    split_lines(s::AbstractString) = Markdown.lines(s)
else
    split_lines(s::AbstractString) = split(s, '\n')
end

@KristofferC
Copy link
Owner

Don't think it will matter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Markdown print error in 1.12.0-DEV
2 participants
@huangyxi @KristofferC